My Drupal Core Contributions for week-ending August 9th, 2024

Last week I was working on a merge request to add the new navigation module to the umami profile. If this is to be merged, then we won't need the toolbar module any more. So I updated that merge request to not install the toolbar module and to also remove toolbar-related permissions from authors and editors.

But after that, things got weird. Well, not weird, but more difficult. We have a message that shows on the toolbar to say "This site is intended for demonstration purposes.", but since we don't have a toolbar any more, well ... what happens to the message? Also, we have tests to make sure the message is in the toolbar, so those tests are now failing.

The options, as I see it, are:

1. Remove the test for the text “This site is for demonstration …” and remove the text “This site is for demonstration …”.
2. Place the text “This site is for demonstration …” somewhere else and update the test.

Update:

I think I have this is a good position now.

1. Remove toolbar from modules to enable in demo_umami.info.yml
2. Add navigation to modules to enable in demo_umami.info.yml
3. Move "This site is intended for demonstration purposes" message from toobar to page_top
4. Rename toolbar-warning library and classes to 'demo-profile-warning' and classes
5. Remove access toolbar from permissions in testDemonstrationWarningMessage test
6. Update permissions for author and editor
7. Update the CSS so there's less of it, it's easier to read and we have the same CSS for small screens and large screens

I'm really looking forward to getting this merged to core, a much larger issue than I had originally intended it to be.

Thanks to <a href='https://www.codeenigma.com/'>Code Enigma</a> for sponsoring my time to work on this.

Filed Under:

1. Drupal Planet
2. Drupal
3. Open Source