Published: July 11, 2024
My Drupal Core Contributions for week-ending July 12th, 2024
Here's what I've been working on for my Drupal contributions this week. Thanks to Code Enigma for sponsoring the time to work on these.
This week was all about helping out in the Stable9 issue queue. Let's see how much we got done thanks to Code Enigma's sponsorship.
- The MR I created last week to ensure that all content in the Umami theme was inside a landmark region was further worked on by my Umami co-maintainer Finnsky. I spent some time further working on this work to tie the rest of the template and CSS together. I think what we have now is a very good layout system that will work just as well for screenreader users.
- I've been tinkering around at the edges of becoming a maintainer of the stable9 theme for a while now, but haven't had much time to work seriously on it. Today I got to have a good look at an issue that has been open for a number of years, saying that the
system-modules-uninstall.html.twig
file has an error with the{% trans %}
tag. After testing, it seems fine, so I think that issue outdated, or at least needs more info. - Drupal 10 updated its library for
off-canvas
, which is being overridden by stable9. However, now stable9 is referencing the old CSS off-canvas files which no longer exist. There's an MR to fix this, which seems to work fine, except there's a test broken somewhere. I'm trying to track it down so we can get this issue finished off and merged. - I think I've tracked down why the tests are failing for the stable9 off_canvas override. All the CSS files for that override were removed so it's not actually trying to override the core library any more. That was a bit more of a rabbit hole than I expected it to be.
- Another stable9 issue whereby the tabledrop handles were not correctly placed. It's been open for years as it was affecting stable theme from Drupal 8. After some digging, I think it's actually a red herring issue and is actually affecting the Seven theme rather than our stable themes, so it's not marked as outdated.
What an enjoyable week that was, and now we have the stable9 issue queue down to only 3 open issues tagged as "Active", or "Needs work", or "Needs review".
Thanks to Code Enigma for again sponsoring my time to make Drupal better for everyone.