Published: July 5, 2024
My Drupal Core Contributions for week-ending July 5th, 2024
Here's what I've been working on for my Drupal contributions this week. Thanks to Code Enigma for sponsoring the time to work on these.
One of the patches I wrote last week got merged on the day I wrote it. That's the fastest I've ever seen an issue go from being reported to being fixed and merged. Let's see how this week goes ...
- All demo content created with the
demo_umami_content
module is created with the same timestamp. This is fine in general, but we have some views that sort items by their created date, which is moot since they all have the same created date and time. Catch created an issue for this, and I created a merge request to set each node as being created one day after the previous node, so our sorting will work better. We have 19 nodes created with the demo content module, so this means:- Node 19 was created yesterday
- Node 18 was created 2 days ago
- Node 17 was created 3 days ago
- and so on
- Sometimes you find gems, such as an accessibility issue we have open for over 5 years noting that the Umami theme does not have all of its content inside HTML landmarks. There's two solutions for this - move all the content that is outside of the
<main>
element to inside it, or create a new<section>
to place all that content. I created a merge request to place all the content inside the<main>
element, at least to get the conversation started. - I started on an issue about 2 years ago to stop using hardcoded CSS values in the Umami theme and start using CSS variables. I had it in such as way that it was ready to merge - I thought - until the issue started expanding to include SVGs as well. Now we've moved half of our Umami CSS to Single-Directory Components, so that MR doesn't work any more. I'm now starting to think about how to get it redone in our SDC-enabled world. That's going to be next week's task.
Woah, another very enjoyable Friday making Drupal core better than it was yesterday. Thanks to Code Enigma for sponsoring this time.