Markie

Published: December 19, 2024

My LocalGov Drupal contributions for week-ending December 20th, 2024

Rewriting a lot of JavaScript and creating a contact component.

Beautifully crafted digital products and experiences that matter.

Need LocalGov Drupal services? Give Big Blue Door a shout.

Meetings and Meet-ups

  1. Merge Tuesdays: I got to two Merge Tuesdays. The first was a great MT. We made progress on - and an approach to getting - dropzone.js added to our default project set up. The second one we got lots of small updates to LocalGov Base merged.
  2. NetCall working group: We regular monthly NetCall catch up where we discuss how we can continue to integrate NetCall's great suite of products with LocalGov Drupal.
  3. Community Meetup: This month, the always-wonderful Rachel Lawson joined us to talk about "fostering community" in open source projects.
  4. Tech Group Drop-in: I only got to one of these meetings this month, between travelling, being sick, and Christmas holidays. It's great to see more and more people joining each week and getting help with any LGD quetions they have. This week we spent some time talking about icons, but most of the time debugging some failing JavaScript tests in the LocalGov Alert Banner module.

Code Contributions

  1. Now that we have our JS and CSS code being linted as part of our CI:CD process (thanks Lee), it has shown up lots of coding standards in our JS files. I took it upon me to fix all of these in the LocalGov Base theme. I thought it would take 30 minutes, but it took over 2 hours, just for the base them.
    1. Fix eslint issues in sticky-header.js
    2. Fix eslint issues in guides.js
    3. Fix eslint issues in subsites-menu.js
    4. Fix eslint issues in add-to-calendar.js
    5. Fix eslint issues in header.js
    6. Fix eslint issues in back-to-top.js
  2. I had planned on doing all the JS files across the whole platform, but honestly, I can think of more exciting things to work on in my wrap up before the Christmas break.
  3. HTML 5 validation is not very good. Drupal's form validation is much better. Here's a PR to disable HTML 5 form validation so Drupal's can be used instead.
  4. There was an issue opened, fixed, and then closed seeking to have a 'Stacked header' pattern for Guides, like the NHS has - basically a title and subtitle wrapped inside the same container. Then we realised no one knows about it, and if they do they need custom code to implement it. So I created a PR in the LocalGov Base repo so site owners could easily turn it on/off for their guides. But then I realised ... guides doesn't have a subtitle field. So I now have lots of more questions and a PR left in WIP until we get this sorted.
  5. We opened an issue in December 2020 (yes, 4 years ago) to say the contact component has no styling, which means each council must individually style it. This costs money, so we now have a PR to make the contact component look good. If you want to amend it, you can but at least out of the box we have a pretty contact component.

Happy Christmas

Happy Christmas everyone! See you all bright and early next year.

Filed Under:

  1. Drupal Planet
  2. Drupal
  3. Open Source
  4. LocalGov Drupal